Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate some APIs in System.Security.Cryptography.* as unsupported on iOS/tvOS #52755

Conversation

MaximLipnin
Copy link
Contributor

Part of #47910

Based on the System.Security.Cryptography.Xml.Tests library tests throwing PNSE on iOS/tvOS:

  • System.Security.Cryptography.Xml.Tests.DSAKeyValueTest.GetXml
  • System.Security.Cryptography.Xml.Tests.DSAKeyValueTest.GetXml_SameDsa
  • System.Security.Cryptography.Xml.Tests.SignedXmlTest.AsymmetricDSASignature

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 14, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #47910

Based on the System.Security.Cryptography.Xml.Tests library tests throwing PNSE on iOS/tvOS:

  • System.Security.Cryptography.Xml.Tests.DSAKeyValueTest.GetXml
  • System.Security.Cryptography.Xml.Tests.DSAKeyValueTest.GetXml_SameDsa
  • System.Security.Cryptography.Xml.Tests.SignedXmlTest.AsymmetricDSASignature
Author: MaximLipnin
Assignees: -
Labels:

area-System.Security, new-api-needs-documentation

Milestone: -

@MaximLipnin MaximLipnin changed the title Annotate some APIs in System.Security,Cryptography.* as unsupported on iOS/tvOS Annotate some APIs in System.Security.Cryptography.* as unsupported on iOS/tvOS May 14, 2021
@filipnavara
Copy link
Member

There is still unresolved (and untracked) issue how do we want to handle DSA.Create() and CryptoConfig on the iOS-like platforms. The current behavior is that it creates a DSA object that thows PNSE on basically all methods (key generation, Sign, Verify) which sounds quite useless. Alternative is to throw PNSE directly in the DSA.Create method and take DSA out of CryptoConfig. It's likely a bit cleaner and could save some code size. Depending on the preferred approach the PNSE/unavailable surface would likely be slightly different. I will file an issue and let someone decide on what is correct.

@filipnavara
Copy link
Member

Superseded by #52978, feedback welcome.

@MaximLipnin
Copy link
Contributor Author

Superseded by #52978, feedback welcome.

Thanks Filip, I'm closing it

@MaximLipnin MaximLipnin deleted the annotate_SSC_apis_as_unsupported_on_ios_tvos branch May 21, 2021 06:52
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants